Slick Forums

Yes -- org.newdawn.slick.shader is obsolete and incomplete.

Sorry liam -- not trying to "take over" your work. If you want to see specific changes/features to my design I'm open to suggestions. Also if you have any criticisms about it then let me know.

@davedes Hey, its completely fine. I've realised now the benefits of your implementation.

I guess one vertex shader plus one fragment shader is okay. But we NEED a TestCase for something like horizontal Blur and vertical Blur. I still have issues on how to make it possible to add more then one effect for a postprocessing effect... But as I can see there is no way but to make one source file which implements all the functions :/

I will use them for sure btw. For wave animations and stuff like that

_________________
Current Projects:


Projects:
- Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!

Pushed ShaderTestAdvanced which shows a simple way to achieve horizontal/vertical blur. Used this tutorial:
http://www.gamerendering.com/2008/10/11 ... er-shader/

The code is a bit messy -- I'll have to clean it up a little.

I guess we can't hide away the messy code for shaders. For blur I once had another shader which was for backgrounds and works with one pass (without the downside of the texture samplings.

_________________
Current Projects:


Projects:
- Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!

i'd be interested to see that. generally speaking blurring in a single pass requires more texture lookups (via texture2D) than blurring in two passes, but i'm sure there are a variety of blur techniques that I'm overlooking...

Here you go:
http://pastebin.com/EMB1n2ay

I'M not exaclty sure who it works but it blur pretty well (Could not find out ho to change the the strengh of the blur). I don't even know where I have this code from xD

_________________
Current Projects:


Projects:
- Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!

From what I gather online and in IRC channels it's not worth the trouble to have "reusable" shaders, or having multiple shaders attach to the same program. Especially because there is no performance/memory benefits of separating shader and program creation: all of the compiling is done when you link the programs. Also this is likely to introduce problems on certain drivers that don't fully support it. I will include a static validate method for users who want to validate a shader without having to create a new program.

Unless anybody strongly feels that they need "reusable" shaders, I will revert to my first draft (no Shader class, just a ShaderProgram which attaches and links everything on construction).

EDIT: Deleted Shader, made ShaderProgram all you need. Advanced users who want to handle compile/link/attach separately can override the empty constructor and use the protected methods.

The only advantage I can see, if I understand everything correctly is that you could implement the Shader as DeferredResource. So the sources of the shaders can be load by any thread during the loading process but the linking is done is the thread that controls OpenGL.

I have no clue how long it takes to compile the shaders. Is it possible to read compiled shaders back and store them as a sort of cache for the local maschine?

Other then that... I "like" the current implementation. My subjective impression of it. Its a nice clear and exspecially selfexplaining structure. In case there are no major disadvantages I would keep it as it is.

Nitram

Loading is not import imho. If you look on games you often see that shaders are compiled and linked at game start. Benchmarking loading time is imho not as important as FPS, meaning how fast works the shader.
Anyway, I'm okay with all. Seems like having a Shader class is really useless xD I thought it might be a good idea but well

If the extension does not work for you it's possible that it does not work on other pc too So I say drop that since I really think if a dev wants something like this he can make it himself just like most of us create their own Ressoure class for ref images/sounds etc.

_________________
Current Projects:


Projects:
- Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!