Slick Forums

Discuss the Slick 2D Library
It is currently Fri Nov 17, 2017 7:18 pm

All times are UTC




Post new topic Reply to topic  [ 6 posts ] 
Author Message
PostPosted: Sat Apr 07, 2012 10:01 am 
I've added a resume() method to ParticleEmitter - "Resumes a particle emitter if it is not completed, after wrapUp() was invoked".

This is useful when you have a particle effect for something such as a flamethrower (my exact use case in my game). When someone starts the flamethrower, the particle emitter gets to full flame, but if they release (and wrapUp() is called), there is no way to go back other than using resetState(), which makes it look messy.


Top
  
 
PostPosted: Sat Apr 07, 2012 10:04 am 
Offline
Game Developer
User avatar

Joined: Thu Mar 03, 2011 6:22 pm
Posts: 534
Would be nice if you stopped adding stuff before suggesting it but in this case I guess it's okay. Please just give the other devs a chance to think about it ;)

_________________
Current Projects:
Image Mr. Hat I
Image Vegan Vs. Zombies
Projects:
RadicalFish Engine - Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!


Top
 Profile  
 
PostPosted: Sat Apr 07, 2012 10:11 am 
Don't worry I've corrected my ways. I thought this one would be okay based on instinct.


Top
  
 
PostPosted: Sat Apr 07, 2012 4:50 pm 
Offline
Slick Zombie

Joined: Sat Jan 27, 2007 7:10 pm
Posts: 1482
Sounds good. I think it's fine to add things without asking first as long as (a) they aren't major changes and (b) they don't break backwards compatibility. If somebody disagrees with any of the changes that pop up here, they can just start a new thread about it.


Top
 Profile  
 
PostPosted: Mon Apr 09, 2012 12:51 pm 
Offline
Game Developer
User avatar

Joined: Thu Mar 03, 2011 6:22 pm
Posts: 534
liamzebedee wrote:
Don't worry I've corrected my ways. I thought this one would be okay based on instinct.


You are right, sorry :) I really think that's okay!

But why did you forget to implement the new function on teh FireEmitter?

_________________
Current Projects:
Image Mr. Hat I
Image Vegan Vs. Zombies
Projects:
RadicalFish Engine - Build on top of Slick2D, Ideas, Bugs? Open an Issue ticket!


Top
 Profile  
 
PostPosted: Tue Apr 24, 2012 12:49 am 
Offline
Slick Zombie

Joined: Sat Jan 27, 2007 7:10 pm
Posts: 1482
Just a note, this breaks FireEmitter in org.newdawn.slick.particles.effects as it now needs to implement the resume method. Not a big deal at all, just don't forget to update that class. :)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group